lkml.org 
[lkml]   [2014]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 0/3] staging: comedi: addi_apci_1564: miscellaneous fixes and cleanups
From
On Thu, Jul 3, 2014 at 4:39 AM, Ian Abbott <abbotti@mev.co.uk> wrote:
> On 2014-07-03 03:15, Chase Southwood wrote:
>>
>> This patchset moves a misplaced include to the proper file, swaps out an
>> overly
>> aggressive placement of apci1564_reset(), and cleans up
>> apci1564_interrupt().
>>
>> Chase Southwood (3):
>> staging: comedi: addi_apci_1564: move addi_watchdog.h include to
>> addi_apci_1564.c
>> staging: comedi: addi_apci_1564: fix use of apci1564_reset() to
>> disable DI interrupts
>> staging: comedi: addi_apci_1564: clean up apci1564_interrupt()
>>
>> .../comedi/drivers/addi-data/hwdrv_apci1564.c | 2 -
>> drivers/staging/comedi/drivers/addi_apci_1564.c | 139
>> +++++----------------
>> 2 files changed, 32 insertions(+), 109 deletions(-)
>>
>
> Looks good! You didn't list the v2 changes though. Maybe you could
> summarize them here?

I always forget to do _something_, don't I? Here are the changes:

CHANGES FROM V1:
*Patches 1 and 2 did not change.
*In Patch 3, check for interrupts from unknown sources has been removed.
*Individual status variables for the subdevices in the interrupt
handler have been swapped out in favor of a single status variable
that is reused for all subdevices.

Thanks,
Chase
>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk.>
>
>
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
> -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-


\
 
 \ /
  Last update: 2014-07-04 05:21    [W:0.063 / U:2.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site