[lkml]   [2014]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v2 0/4] Tegra USB probe order issue fix
Hi all,

Here's a second version of the probe order issue series. This time I've
added the USB1 resets to the PHYs, thus replacing the really ugly parts
with something slightly better. Old device trees will still probe
successfully, but instead of this bugfix they'll get a dev_warn().

The reset control patch was dropped, as a similar patch from someone
else has landed in linux-next.

For a recap of the issue from the previous series:

Basically, the register area of the 1st USB controller contains some
registers that are global to all of the controllers, but that are also
cleared when reset is asserted to the 1st controller. So if (say) the
3rd controller would be the first one to finish probing successfully,
then the reset that happens during the 1st controller's probe would
result in broken USB. So the before doing anything with the USB HW,
we should reset the 1st controller once, and then never ever reset
it again.

While testing that the 1st USB controller still works without a reset
when the driver is unbound and bound again, I discovered an unbalanced
regulator_disable + clk_disable_unprepare in the PHY code if the EHCI
driver is unbound and rebound. This is fixed in patch 4.


Tuomas Tynkkynen (4):
USB: tegra: Add resets & has-utmi-pad-registers flag to the PHY
ARM: tegra: Add resets & has-utmi-pad-registers flag to all USB PHYs
USB: EHCI: tegra: Fix probe order issue leading to broken USB
USB: PHY: tegra: Call tegra_usb_phy_close only on device removal

.../bindings/usb/nvidia,tegra20-usb-phy.txt | 8 +++
arch/arm/boot/dts/tegra114.dtsi | 5 ++
arch/arm/boot/dts/tegra124.dtsi | 7 +++
arch/arm/boot/dts/tegra20.dtsi | 7 +++
arch/arm/boot/dts/tegra30.dtsi | 7 +++
drivers/usb/host/ehci-tegra.c | 62 +++++++++++++++++++-
drivers/usb/phy/phy-tegra-usb.c | 8 +--
7 files changed, 96 insertions(+), 8 deletions(-)


 \ /
  Last update: 2014-07-04 04:01    [W:0.108 / U:112.372 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site