lkml.org 
[lkml]   [2014]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/12] drm/exynos/ipp: remove temporary variable
    Date
    There is no reason to allocate intermediate variable.

    Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
    ---
    drivers/gpu/drm/exynos/exynos_drm_ipp.c | 14 ++++++--------
    1 file changed, 6 insertions(+), 8 deletions(-)

    diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
    index f3d8b5c..f84ef8a 100644
    --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
    +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
    @@ -680,15 +680,14 @@ static struct drm_exynos_ipp_mem_node
    struct drm_exynos_ipp_queue_buf *qbuf)
    {
    struct drm_exynos_ipp_mem_node *m_node;
    - struct drm_exynos_ipp_buf_info buf_info;
    + struct drm_exynos_ipp_buf_info *buf_info;
    int i;

    m_node = kzalloc(sizeof(*m_node), GFP_KERNEL);
    if (!m_node)
    return ERR_PTR(-ENOMEM);

    - /* clear base address for error handling */
    - memset(&buf_info, 0x0, sizeof(buf_info));
    + buf_info = &m_node->buf_info;

    /* operations, buffer id */
    m_node->ops_id = qbuf->ops_id;
    @@ -712,15 +711,14 @@ static struct drm_exynos_ipp_mem_node
    goto err_clear;
    }

    - buf_info.handles[i] = qbuf->handle[i];
    - buf_info.base[i] = *addr;
    - DRM_DEBUG_KMS("i[%d]base[0x%x]hd[0x%x]\n",
    - i, buf_info.base[i], (int)buf_info.handles[i]);
    + buf_info->handles[i] = qbuf->handle[i];
    + buf_info->base[i] = *addr;
    + DRM_DEBUG_KMS("i[%d]base[0x%x]hd[0x%lx]\n", i,
    + buf_info->base[i], buf_info->handles[i]);
    }
    }

    m_node->filp = file;
    - m_node->buf_info = buf_info;
    mutex_lock(&c_node->mem_lock);
    list_add_tail(&m_node->list, &c_node->mem_list[qbuf->ops_id]);
    mutex_unlock(&c_node->mem_lock);
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-07-03 16:01    [W:4.112 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site