lkml.org 
[lkml]   [2014]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 10/21] slab_common: Do not check for duplicate slab names
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Christoph Lameter <cl@linux.com>

    commit 3e374919b314f20e2a04f641ebc1093d758f66a4 upstream.

    SLUB can alias multiple slab kmem_create_requests to one slab cache to save
    memory and increase the cache hotness. As a result the name of the slab can be
    stale. Only check the name for duplicates if we are in debug mode where we do
    not merge multiple caches.

    This fixes the following problem reported by Jonathan Brassow:

    The problem with kmem_cache* is this:

    *) Assume CONFIG_SLUB is set
    1) kmem_cache_create(name="foo-a")
    - creates new kmem_cache structure
    2) kmem_cache_create(name="foo-b")
    - If identical cache characteristics, it will be merged with the previously
    created cache associated with "foo-a". The cache's refcount will be
    incremented and an alias will be created via sysfs_slab_alias().
    3) kmem_cache_destroy(<ptr>)
    - Attempting to destroy cache associated with "foo-a", but instead the
    refcount is simply decremented. I don't even think the sysfs aliases are
    ever removed...
    4) kmem_cache_create(name="foo-a")
    - This FAILS because kmem_cache_sanity_check colides with the existing
    name ("foo-a") associated with the non-removed cache.

    This is a problem for RAID (specifically dm-raid) because the name used
    for the kmem_cache_create is ("raid%d-%p", level, mddev). If the cache
    persists for long enough, the memory address of an old mddev will be
    reused for a new mddev - causing an identical formulation of the cache
    name. Even though kmem_cache_destory had long ago been used to delete
    the old cache, the merging of caches has cause the name and cache of that
    old instance to be preserved and causes a colision (and thus failure) in
    kmem_cache_create(). I see this regularly in my testing.

    Reported-by: Jonathan Brassow <jbrassow@redhat.com>
    Signed-off-by: Christoph Lameter <cl@linux.com>
    Signed-off-by: Pekka Enberg <penberg@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    mm/slab_common.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/mm/slab_common.c
    +++ b/mm/slab_common.c
    @@ -55,6 +55,7 @@ static int kmem_cache_sanity_check(struc
    continue;
    }

    +#if !defined(CONFIG_SLUB) || !defined(CONFIG_SLUB_DEBUG_ON)
    /*
    * For simplicity, we won't check this in the list of memcg
    * caches. We have control over memcg naming, and if there
    @@ -68,6 +69,7 @@ static int kmem_cache_sanity_check(struc
    s = NULL;
    return -EINVAL;
    }
    +#endif
    }

    WARN_ON(strchr(name, ' ')); /* It confuses parsers */



    \
     
     \ /
      Last update: 2014-07-30 05:21    [W:2.472 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site