Messages in this thread | | | Date | Tue, 29 Jul 2014 15:47:07 -0700 (PDT) | Subject | Re: [PATCH] net: irda: delete double assignment | From | David Miller <> |
| |
From: Himangi Saraogi <himangi774@gmail.com> Date: Mon, 28 Jul 2014 20:58:12 +0530
> @@ -621,7 +621,6 @@ void irlap_send_rd_frame(struct irlap_cb *self) > > frame = (struct rd_frame *)skb_put(tx_skb, 2); > > - frame->caddr = self->caddr; > frame->caddr = RD_RSP | PF_BIT; >
This doesn't look correct to me.
I think both lines should be kept, and the second line should be changed to assign those bits to frame->control.
This is consistent with other parts of the file that make use of the PF_BIT.
| |