Messages in this thread | | | Date | Tue, 29 Jul 2014 22:17:31 +0800 | From | caesar <> | Subject | Re: [PATCH v2 2/2] pwm: add this patch to support the new pwm of Rockchip SoCs |
| |
Thierry,
在 2014年07月29日 19:38, Thierry Reding 写道: > On Tue, Jul 29, 2014 at 07:09:07PM +0800, caesar wrote: >> Thierry, >> >> 在 2014年07月29日 18:22, Thierry Reding 写道: >>> On Mon, Jul 28, 2014 at 07:19:18PM +0800, caesar wrote: >>>> Doug, >>>> 在 2014年07月28日 12:01, Doug Anderson 写道: >>>>> Caesar, >>>>> >>>>> On Sun, Jul 27, 2014 at 7:00 AM, caesar <caesar.wang@rock-chips.com> wrote: >>>>>> /*I think will be show the faill log:-> >>>>>> >>>>>> * rockchip-pwm ff9301a0.pwm: can't request region for resource [mem >>>>>> 0xff9301a0-0xff93019f] >>>>>> */ >>>>>> >>>>>> pc->base = devm_ioremap_resource(dev, regs); >>>>> Did you actually code this up and try it and get this error? >>>> Yeah. >>> This should work if you properly set up the PWM subregion as a child of >>> the LCDC region, which is what MFD will do for you. >>> >>> Thierry >> As you say,should this change be occured by lcdc driver and dts? >> >> The PWM driver don't need do any changes? > No, I don't think the PWM driver needs to be changed for the above to > work. > > Thierry Ok, as you suggestions, The PWM driver :
static int rockchip_pwm_probe (...) {
...
r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pc->base = devm_ioremap_resource(&pdev->dev, r); + if (!strcmp(of_id->compatible, "rockchip,vop-pwm")) + pc->base = devm_ioremap(&pdev->dev, r->start, resource_size(r)); + else + pc->base = devm_ioremap_resource(&pdev->dev, r);
...
}
This will be fixed for following:
static int rockchip_pwm_probe (...) {
...
r = platform_get_resource(pdev, IORESOURCE_MEM, 0); pc->base = devm_ioremap_resource(&pdev->dev, r);
...
}
I will discuss with lcdc of upstream's people tomorrow.
I has sent the PWM in patch v4 the last few days,Hope you can help check and accept it,thanks.:-)
-caesar
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |