Messages in this thread | | | Date | Tue, 29 Jul 2014 10:06:50 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 22/27] perf tools: Enable --children option by default |
| |
Em Tue, Jul 29, 2014 at 01:45:48PM +0200, Andres Freund escreveu: > On 2014-07-29 15:52:46 +0900, Namhyung Kim wrote: > > Yes, I knew it'd annoy some existing users like you :)
And me :-)
> > But I hoped it'd be useful for new and (at least, some of) old users > > to see children/ cumulative overheads by default. If it lies under > > an option, it wouldn't have a chance to be used by normal users who > > simply run perf record and report most of time.
> By that argument every new feature would need to be enabled by > default. Which normally isn't what happens.
> > If you think it's entirely useless for you cases, you can set it to off > > using ~/.perfconfig file:
> > [report] > > children = false
> Already done that ;).
:-)
> The problem is still that I can't use --no-children on older systems, so > I can't write benchmarking scripts anymore that don't take depend on the > perf version...
> I guess it's too late to argue effectively though :)
yeah, changing the output people are used to in such a big way is not nice.
Perhaps next time we should instead present a dialog box at 'perf report' start allowing people to opt-in, having a nice explanation about why one would want to switch the default while alowing people to say:
[x] No, Thanks
- Arnaldo
| |