lkml.org 
[lkml]   [2014]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v4 0/3] ring-buffer/ftrace: Race when writing and swapping cpu buffer in parallel
Date
OK, I ended with these changes after changing my mind few times and hopefully
better understanding the aspects of preemption, interrupts, locking, and
scheduling.

1st patch fixes the race in ring_buffer_swap_cpu(). It is the one from previous
versions. I have only added checks for irqs_disabled() as suggested by Steven.

2nd patch should be easy. It only makes sure that we are on the same CPU
when handling the critical timings.

3rd patch was the most problematic for me. It creates two variants
of smp_call_function_single() that could be called either with or without
disabled interrupts. It is what Steven suggested but I wonder if it could
be done more elegant way. I am in somewhat strange mode after the twins were
born on Thursday.

Petr Mladek (3):
ring-buffer: Race when writing and swapping cpu buffer in parallel
trace: process entire stop_critical_timing() on the same CPU
trace: Allow to call update_max_tr_single() from another CPU

kernel/trace/ring_buffer.c | 115 ++++++++++++++++++++++++++++++-------------
kernel/trace/trace.c | 60 +++++++++++++++++++---
kernel/trace/trace.h | 1 +
kernel/trace/trace_irqsoff.c | 17 +++++--
4 files changed, 146 insertions(+), 47 deletions(-)

--
1.8.4



\
 
 \ /
  Last update: 2014-07-29 15:21    [W:0.038 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site