lkml.org 
[lkml]   [2014]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH v2] ASoC: wm8962: Let CODEC driver enable and disable its own MCLK
On Tue, Jul 29, 2014 at 10:52:03AM +0100, Mark Brown wrote:
> On Tue, Jul 29, 2014 at 10:55:19AM +0800, Nicolin Chen wrote:
> > On Mon, Jul 28, 2014 at 03:19:43PM -0300, Fabio Estevam wrote:
>
> > > >> + pdata->mclk = devm_clk_get(&i2c->dev, NULL);
>
> > > > This is broken for deferred probe.
>
> > Sorry. I don't get why deferred probe would be broken by this.
> > And I just took a test by adding this:
>
> I don't see the code that actually pays attention to the return value
> from devm_clk_get() - in the main probe function the code just treats
> all errors as a missing MCLK.

Just checked the clk_get() code and got the point.

I will add a check to it and return for EPROBE_DEFER.

Thank you,
Nicolin


\
 
 \ /
  Last update: 2014-07-29 13:01    [W:0.049 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site