Messages in this thread | | | Date | Tue, 29 Jul 2014 18:19:51 +0800 | From | Nicolin Chen <> | Subject | Re: [alsa-devel] [PATCH v2] ASoC: wm8962: Let CODEC driver enable and disable its own MCLK |
| |
On Tue, Jul 29, 2014 at 10:52:03AM +0100, Mark Brown wrote: > On Tue, Jul 29, 2014 at 10:55:19AM +0800, Nicolin Chen wrote: > > On Mon, Jul 28, 2014 at 03:19:43PM -0300, Fabio Estevam wrote: > > > > >> + pdata->mclk = devm_clk_get(&i2c->dev, NULL); > > > > > This is broken for deferred probe. > > > Sorry. I don't get why deferred probe would be broken by this. > > And I just took a test by adding this: > > I don't see the code that actually pays attention to the return value > from devm_clk_get() - in the main probe function the code just treats > all errors as a missing MCLK.
Just checked the clk_get() code and got the point.
I will add a check to it and return for EPROBE_DEFER.
Thank you, Nicolin
| |