lkml.org 
[lkml]   [2014]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2 v4] sched: Rewrite per entity runnable load average tracking
On Mon, Jul 28, 2014 at 07:19:09PM +0200, Peter Zijlstra wrote:
> > > And here we try and make good on that assumption. The thing I worry
> > > about is what happens if the machine is entirely idle...
> > >
> > > What guarantees an semi up-to-date cfs_rq->avg.last_update_time.
> >
> > update_blocked_averages I think should do just as good a job as the old
> > code, which isn't perfect but is about as good as you can get worst case.
>
> Right, that's called from rebalance_domains() which should more or less
> update this value on tick boundaries or thereabouts for most 'active'
> cpus.
>
> But if the entire machine is idle, the first wakeup (if its a x-cpu one)
> might see a very stale timestamp.
>
> If we can fix that, that would be good I suppose, but I'm not
> immediately seeing something pretty there, but you're right, it'd not be
> worse than the current situation.

It matters time is up-to-date before load_avg is actually used. So yes, we should
have already achieved that.


\
 
 \ /
  Last update: 2014-07-29 12:01    [W:0.073 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site