Messages in this thread Patch in this message | | | Date | Mon, 28 Jul 2014 20:59:38 +0530 | From | Himangi Saraogi <> | Subject | [PATCH] svcrdma: delete double assignment |
| |
Delete successive assignments to the same location.
A simplified version of Coccinelle semantic match that finds this problem is as follows:
// <smpl> @@ expression i; @@
*i = ...; i = ...; // </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com> --- Should the assignment be the maximum of the 2 values? net/sunrpc/xprtrdma/svc_rdma_transport.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index 06a5d92..8976529 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -956,7 +956,6 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) dprintk("svcrdma: failed to create QP, ret=%d\n", ret); goto errout; } - newxprt->sc_max_sge = qp_attr.cap.max_send_sge; newxprt->sc_max_sge = qp_attr.cap.max_recv_sge; newxprt->sc_sq_depth = qp_attr.cap.max_send_wr; newxprt->sc_max_requests = qp_attr.cap.max_recv_wr; -- 1.9.1
| |