Messages in this thread | | | From | Grant Likely <> | Subject | Re: [RFC PATCH 2/2] of/clk: use "clkops-clocks" to specify clocks handled by clock_ops domain | Date | Mon, 28 Jul 2014 08:05:33 -0600 |
| |
On Thu, 12 Jun 2014 19:53:43 +0300, Grygorii Strashko <grygorii.strashko@ti.com> wrote: > Use "clkops-clocks" property to specify clocks handled by > clock_ops domain PM domain. Only clocks defined in "clkops-clocks" > set of clocks will be handled by Runtime PM through clock_ops > Pm domain. > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > drivers/of/of_clk.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/of/of_clk.c b/drivers/of/of_clk.c > index 35f5e9f..5f9b90e 100644 > --- a/drivers/of/of_clk.c > +++ b/drivers/of/of_clk.c > @@ -86,11 +86,8 @@ int of_clk_register_runtime_pm_clocks(struct device_node *np, > struct clk *clk; > int error; > > - for (i = 0; (clk = of_clk_get(np, i)) && !IS_ERR(clk); i++) { > - if (!clk_may_runtime_pm(clk)) { > - clk_put(clk); > - continue; > - } > + for (i = 0; (clk = of_clk_get_from_set(np, "clkops", i)) && > + !IS_ERR(clk); i++) {
This really looks like an ABI break to me. What happens to all the existing platforms who don't have this new clkops-clocks in their device tree?
g.
| |