Messages in this thread | | | Subject | Re: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS | From | Benoit Masson <> | Date | Mon, 28 Jul 2014 13:17:56 +0200 |
| |
Le 28 juil. 2014 à 13:02, Arnd Bergmann <arnd@arndb.de> a écrit :
> On Monday 28 July 2014 12:50:47 Benoit Masson wrote: >>> >>> It should still list both "marvell,mv78230-i2c" and "marvell,mv64xxx-i2c", >>> as the generic name may not be enough to describe the register layout >>> correctly. >> >> I tend to disagree since the dts include the armada-xp.dtsi, which already declare >> >> "i2c0: i2c@11000 { >> compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c"; >> reg = <0x11000 0x100>; >> }; >> " >> >> I tested the dts on the device and it does inherits the i2c declaration, did I miss something here ? >> > > Inheriting from armada-xp.dtsi is fine, but if you manually set > "marvell,mv64xxx-i2c", that will override the old setting > and drop the "marvell,mv78230-i2c" part, which is bad because > it may break things later if it turns out that the mv78230 > variant is not completely compatible with the old > mv64xxx variant.
Ok then does this mean I can simply remove the "compatible" line to only inherits from armada-xp-dtsi ?
"i2c@11000 { clock-frequency = <400000>; status = "okay"; "
Would this be enough ?
Benoit > > Arnd
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |