Messages in this thread Patch in this message | | | From | Rickard Strandqvist <> | Subject | [PATCH] arch: s390: kernel: ipl.c: Cleaning up missing null-terminate in conjunction with strncpy | Date | Sat, 26 Jul 2014 16:01:31 +0200 |
| |
Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- arch/s390/kernel/ipl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c index 633ca75..405367b 100644 --- a/arch/s390/kernel/ipl.c +++ b/arch/s390/kernel/ipl.c @@ -226,7 +226,7 @@ static ssize_t sys_##_prefix##_##_name##_store(struct kobject *kobj, \ struct kobj_attribute *attr, \ const char *buf, size_t len) \ { \ - strncpy(_value, buf, sizeof(_value) - 1); \ + strlcpy(_value, buf, sizeof(_value)); \ strim(_value); \ return len; \ } \ @@ -1959,7 +1959,7 @@ void __init setup_ipl(void) ipl_info.data.fcp.lun = IPL_PARMBLOCK_START->ipl_info.fcp.lun; break; case IPL_TYPE_NSS: - strncpy(ipl_info.data.nss.name, kernel_nss_name, + strlcpy(ipl_info.data.nss.name, kernel_nss_name, sizeof(ipl_info.data.nss.name)); break; case IPL_TYPE_UNKNOWN: -- 1.7.10.4
| |