lkml.org 
[lkml]   [2014]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: drivers: fix return value of get_mode callback
On Thu, Jul 24, 2014 at 03:15:25PM +0530, Laxman Dewangan wrote:
> On Monday 14 July 2014 11:31 PM, Mark Brown wrote:
> >On Mon, Jul 14, 2014 at 12:57:18PM +0100, Charles Keepax wrote:
> >>On Mon, Jul 14, 2014 at 04:03:17PM +0530, Laxman Dewangan wrote:

> >It's because it's returning something defined as a bitmask, though since
> >we don't even have enough modes for 8 bits that's not really a strong
> >reason and we should just be returning an error code as everyone is
> >clearly already assuming we do.

> Just to confirm, do you want to change the return type of get_mode() to
> "int" instead of
> unsigned int? And then return proper error type?

Yes.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-07-25 21:21    [W:2.594 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site