lkml.org 
[lkml]   [2014]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] staging: comedi: amplc_dio200_common: remove some tests from amplc_dio200_common_detach()
    Date
    `amplc_dio200_common_detach()` doesn't do much apart from freeing the
    IRQ handler that was requested by `amplc_dio200_common_attach()` if
    `dev->irq` is non-zero. There is no need to check if the pointer to
    the constant board data or the pointer to private per-device data
    exist, so remove those tests.

    Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
    ---
    drivers/staging/comedi/drivers/amplc_dio200_common.c | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/drivers/staging/comedi/drivers/amplc_dio200_common.c b/drivers/staging/comedi/drivers/amplc_dio200_common.c
    index 3592e58..4cf9e9e 100644
    --- a/drivers/staging/comedi/drivers/amplc_dio200_common.c
    +++ b/drivers/staging/comedi/drivers/amplc_dio200_common.c
    @@ -1197,11 +1197,6 @@ EXPORT_SYMBOL_GPL(amplc_dio200_common_attach);

    void amplc_dio200_common_detach(struct comedi_device *dev)
    {
    - const struct dio200_board *thisboard = comedi_board(dev);
    - struct dio200_private *devpriv = dev->private;
    -
    - if (!thisboard || !devpriv)
    - return;
    if (dev->irq) {
    free_irq(dev->irq, dev);
    dev->irq = 0;
    --
    2.0.0


    \
     
     \ /
      Last update: 2014-07-25 20:01    [W:2.795 / U:0.508 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site