[lkml]   [2014]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests
>>>>> "Sitsofe" == Sitsofe Wheeler <> writes:

Sitsofe> Fix incorrectly named variable. Some block devices (such as
Sitsofe> Hyper-V passthrough SSDs) support logical block provisioning
Sitsofe> (e.g. via UNMAP) but don't set lbpme thus disabling discard.

The fix for an SSD that is known to support LBP but which does not claim
support for it is to use:

echo unmap > /sys/class/scsi_disk/foo/provisioning_mode

I'm very much against short-circuiting the LBP logic in a passthrough
driver because then we might end up in the exact situation we were
trying to avoid with this patch series. Namely sending down commands
unsupported by the target device.

This kind of thing really needs to be a sysadmin decision and can be
handled with a udev rule.

Martin K. Petersen Oracle Linux Engineering

 \ /
  Last update: 2014-07-24 16:41    [W:0.094 / U:5.792 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site