Messages in this thread | | | Date | Thu, 24 Jul 2014 14:47:48 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 4/6] perf report: Honor column width setting |
| |
On Wed, Jul 09, 2014 at 02:28:12PM +0900, Namhyung Kim wrote: > Set column width and do not change it if user gives -w/--column-widths > option. It'll truncate longer symbols than the width if exists.
SNIP
> > static inline void advance_hpp(struct perf_hpp *hpp, int inc) > { > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > index 396b0094943d..f89714329c0f 100644 > --- a/tools/perf/util/sort.c > +++ b/tools/perf/util/sort.c > @@ -70,7 +70,9 @@ static int hist_entry__thread_snprintf(struct hist_entry *he, char *bf, > size_t size, unsigned int width) > { > const char *comm = thread__comm_str(he->thread); > - return repsep_snprintf(bf, size, "%-*s:%5d", width - 6, > + > + width = max(7U, width) - 6; > + return repsep_snprintf(bf, size, "%-*.*s:%5d", width, width, > comm ?: "", he->thread->tid);
I couldn't found what your format string: "%-*.*s:%5d", width, width
is supposed to do... it gives me the same result as for: "%-*s:%5d", width
you use it on more places so I guess it's not a typo ;-)
thanks, jirka
| |