Messages in this thread | | | Date | Wed, 23 Jul 2014 16:52:39 +0200 | Subject | Re: [PATCH v2] mmc: mmci: Add qcom dml support to the driver. | From | Linus Walleij <> |
| |
On Fri, Jul 18, 2014 at 10:53 PM, Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote:
> On Qualcomm APQ8064 SOCs, SD card controller has an additional glue > called DML (Data Mover Local/Lite) to assist dma transfers. > This hardware needs to be setup before any dma transfer is requested. > DML itself is not a DMA engine, its just a gule between the SD card > controller and dma controller. > > Most of this code has been ported from qualcomm's 3.4 kernel. > > This patch adds the code necessary to intialize the hardware and setup > before doing any dma transfers. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > Changes since v1: > - Added licence text as spotted by Stephen B. > - Simplified dma channel lookup as suggested by Stephen B. > - Removed unnecessary parens spotted by Stephen B. > - in general some cleanup done. > > Changes since RFC: > - Moved qcom_dml.* to mmci_qcom_dml.* as suggested by Linus W. > - added BAM DMA dependency in Kconfig as suggested by Linus W
I really like this v2 version. Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |