Messages in this thread | | | Date | Wed, 23 Jul 2014 11:10:06 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH] workqueue: get the probable node ID from the first CPU of the mask |
| |
On Wed, Jul 23, 2014 at 09:26:30AM +0800, Lai Jiangshan wrote: > On 07/22/2014 11:30 PM, Tejun Heo wrote: > > On Tue, Jul 22, 2014 at 01:04:02PM +0800, Lai Jiangshan wrote: > >> + node = cpu_to_node(cpumask_first(pool->attrs->cpumask)); > > > > Minor but maybe cpumask_any() is a better fit here? > > > > It is OK, the result are the same. But I still think cpumask_first() is better since > its name sounds deterministic while we need a deterministic value for pool->node.
The CPU can be any CPU in the mask. That's the whole point of cpumask_any(). Please use it.
-- tejun
| |