lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS
    On Thu, Jul 24, 2014 at 01:29:09AM +0200, Andrew Lunn wrote:
    > > On Wed, Jul 23, 2014 at 03:52:53PM -0700, Benoit Masson wrote:
    > > > The Lenovo Iomega ix4-300d is a 4-Bay sata NAS with dual Gb,
    > > > USB2.0 & 3.0, powered by a Marvell Armada XP MV78230 dual core CPU.
    > > >
    > > > http://shop.lenovo.com/fr/fr/servers/network-storage/lenovoemc/ix4-300d/
    > > > Signed-off-by: Benoit Masson <yahoo@perenite.com>
    > > > ---
    > > > arch/arm/boot/dts/Makefile | 3 +-
    > > > arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 284 ++++++++++++++++++++++++
    > > > 2 files changed, 286 insertions(+), 1 deletion(-)
    > > > create mode 100644 arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
    > > ...
    > > > diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
    > > > new file mode 100644
    > > > index 0000000..1f33cbc
    > > > --- /dev/null
    > > > +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
    > > ...
    > > > + /* Warning: you need both eth1 & 0 PHY initialized
    > > > + (i.e having them up does the tweak)
    > > > + for poweroff to shutdown otherwise it reboots */
    > >
    > > nit: multi-line comments are like this:
    > >
    > > /*
    > > * Warning: you need both eth1 & 0 PHY initialized (i.e having
    > > * them up does the tweak) for poweroff to shutdown otherwise it
    > > * reboots
    > > */
    > >
    > > If that's the only thing left, I'll fix it up when I pull it in. No
    > > need to respin just for this.
    >
    > Hi Jason
    >
    > We should not really leave the i2c compatibility string as it is.

    Agreed.

    > Hopefully the OEM moved onto B1 stepping at some point. Although B1
    > devices will work with the workaround, you get better performance
    > without it.
    >
    > We should wait for Gregory to look at the quirk and soc-id code.

    Yep.

    thx,

    Jason.


    \
     
     \ /
      Last update: 2014-07-24 02:41    [W:3.112 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site