Messages in this thread | | | Date | Wed, 23 Jul 2014 13:33:32 -0500 | From | David Teigland <> | Subject | Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type |
| |
On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote: > On Sun, 20 Jul 2014 11:23:43 -0700 > Joe Perches <joe@perches.com> wrote: > > > op->info.rv is an s32, but it's only used as a u8. > > > > I don't understand this patch. info.rv is s32 (and I assume that "rv" > stands for "return value"). What I don't get is why you think it's just > used as a u8. It seems to be used more like a bool than anything else,
Thank you, Jeff.
/* info.rv from userspace is 1 for conflict, 0 for no-conflict, -ENOENT if there are no locks on the file */
rv = op->info.rv;
> and I'm not sure that "type" is really a good description for it. Maybe > it should be a "bool" and named "conflict", given the comments in > dlm_posix_get ?
type is not a good name.
Sorry Joe, I'm not a fan of your patches.
Dave
| |