Messages in this thread | | | Date | Wed, 23 Jul 2014 16:26:41 -0400 | From | Theodore Ts'o <> | Subject | Re: [PATCH] random: fix 32MB+ reads from /dev/urandom |
| |
I don't think this patch is worthwhile. There is no legitimate reason to be using such large reads like this, and read(2) is always allowed to return a short read (for example, if a signal comes in while the read is happening). The only difference is that we are now guaranteed to return a short-read if you try to read more than 32MB. Given that there is no valid reason to ask for more than 256 or maybe 512 bytes at a time, I'm not particularly worried about this.
If you really care, you can ask dd keep reading after a short read by using "iflag=fullblock".
- Ted
| |