Messages in this thread | | | Date | Wed, 23 Jul 2014 20:31:17 +0200 | From | Peter Zijlstra <> | Subject | Re: Random panic in load_balance() with 3.16-rc |
| |
On Wed, Jul 23, 2014 at 11:07:40AM -0700, Linus Torvalds wrote:
> - *static* per-cpu allocations might want to use "cpumask_var_t" (to > avoid having a full "struct cpumask_t") along with doing a > "zalloc_cpumask_var_node(..)" for each cpu. > > sched_init() follows that last pattern, except it open-codes that > zalloc_cpumask_var_node() in an odd way that confused me. > > So I take my patch back. It's wrong, because it only allocates that > cpumask_size() if CONFIG_CPUMASK_OFFSTACK is true.
What it doesn't do is keep the allocation on the right node, so killing that stuff is helping more than just readability.
| |