Messages in this thread | | | Date | Wed, 23 Jul 2014 14:54:09 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH] power: add driver for battery reading on iPaq h3xxx |
| |
Hi Linus,
On Sat, Jul 12, 2014 at 11:33:49AM +0200, Linus Walleij wrote: > [...] > + > +#define BATT_PERIOD 100000 /* 10 seconds in milliseconds */
that's 100 seconds...
> [...] > + > +struct micro_battery { > + struct ipaq_micro *micro; > + struct workqueue_struct *wq; > + struct delayed_work update; > + u8 ac; > + u8 chemistry; > + unsigned int voltage; > + u16 temperature; > + u8 flag; > +}; > + > [...] > + > +static struct power_supply micro_battery = { ^^^^^^^^^^^^^ I would prefer to have a name different from the struct defined above.
> [...]
-- Sebastian [unhandled content-type:application/pgp-signature] | |