Messages in this thread | | | Date | Wed, 23 Jul 2014 10:46:49 +0200 | Subject | Re: linux-next: build warnings after merge of the gpio tree | From | Linus Walleij <> |
| |
On Wed, Jul 23, 2014 at 10:45 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> After merging the gpio tree, today's linux-next build (powerpc > allyesconfig) produced these warnings: > > drivers/gpio/gpio-ucb1400.c: In function 'ucb1400_gpio_remove': > drivers/gpio/gpio-ucb1400.c:92:2: warning: ignoring return value of 'gpiochip_remove', declared with attribute warn_unused_result [-Wunused-result] > gpiochip_remove(&ucb->gc); > ^ > > And lots of similar ones. > > Introduced by commit 9f5132ae82fd ("gpio: remove all usage of > gpio_remove retval in driver/gpio").
Yes we're planning to get rid of the retval in the next merge window after first purging all drivers.
> Maybe the __must_check attribute should be removed from the declaration > of the function before removing the retval checking ...
Hey, good idea. I'll do this.
Yours, Linus Walleij
| |