Messages in this thread | | | Date | Wed, 23 Jul 2014 00:56:21 -0400 | Subject | Re: [PATCH] m68k: Remove printk statement and add return statement in q40ints.c | From | Nick Krause <> |
| |
On Wed, Jul 23, 2014 at 12:54 AM, Guenter Roeck <linux@roeck-us.net> wrote: > On 07/22/2014 09:08 PM, Nicholas Krause wrote: >> >> This removes the printk statement for irqs not defined by the hardware in >> function q40_irq_startup and instead returns -ENXIO as stated by the fix >> me message. >> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> >> --- >> arch/m68k/q40/q40ints.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c >> index 513f9bb..86f05c0 100644 >> --- a/arch/m68k/q40/q40ints.c >> +++ b/arch/m68k/q40/q40ints.c >> @@ -48,8 +48,7 @@ static unsigned int q40_irq_startup(struct irq_data >> *data) >> switch (irq) { >> case 1: case 2: case 8: case 9: >> case 11: case 12: case 13: >> - printk("%s: ISA IRQ %d not implemented by HW\n", __func__, >> irq); >> - /* FIXME return -ENXIO; */ >> + return -ENXIO; > > > Returning -ENXIO from a function returning an unsigned int isn't really very > helpful, > don't you think ? > > With all those FIXMEs, you might want to keep in mind that there is > typically a > good reason for it. If it was as easy as your proposed fix, you can assume > that the FIXME would not have been there in the first place. > > Guenter >
Sorry Guenter, That's fine. can I can change the return type of the function or is that going to break things? Nick
| |