lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ix86: fix vDSO build
>>> On 11.07.14 at 00:58, <hpa@zytor.com> wrote:
> On 07/03/2014 07:35 AM, Jan Beulich wrote:
>> Relying on static functions used just once to get inlined (and
>> subsequently have dead code paths eliminated) is wrong: Compilers are
>> free to decide whether they do this, regardless of optimization level.
>> With this not happening for vdso_addr() (observed with gcc 4.1.x), an
>> unresolved reference to align_vdso_addr() causes the build to fail.
>
> The fix seems odd... more of the flavor of "happens to work" unless I'm
> misunderstanding something. If this needs to be inlined, wouldn't
> __always_inline make more sense?
>
> What am I missing?

I think this is a matter of taste: Personally I think __always_inline should
be used rather rarely, as it takes away decisions from the compiler that
it would (generally) be in the better position to make.

Sorry for the late reply (was on vacation),
Jan



\
 
 \ /
  Last update: 2014-07-23 11:01    [W:0.112 / U:14.004 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site