Messages in this thread | | | Date | Tue, 22 Jul 2014 09:55:15 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH V3] perf tools: Record whether a dso has data |
| |
On Thu, Jul 17, 2014 at 11:58:30AM +0300, Adrian Hunter wrote: > Add 'data_status' to record whether a dso has data > (i.e. an object file)
I might have seen it in your last patsent, but forgot.. what is this data_status going to be used for?
SNIP
> diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h > index c239e86..07d0a58 100644 > --- a/tools/perf/util/dso.h > +++ b/tools/perf/util/dso.h > @@ -40,6 +40,12 @@ enum dso_swap_type { > DSO_SWAP__YES, > }; > > +enum dso_data_status { > + DSO_DATA_STATUS_ERROR = -1, > + DSO_DATA_STATUS_UNKNOWN = 0, > + DSO_DATA_STATUS_OK = 1, > +}; > + > #define DSO__SWAP(dso, type, val) \ > ({ \ > type ____r = val; \ > @@ -104,6 +110,7 @@ struct dso { > struct { > struct rb_root cache; > int fd; > + int data_status;
also please call it just 'status' it's already in 'data' struct
thanks, jirka
| |