lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] Lattice ECP3 FPGA: Correct endianness
On Mon, Jul 21, 2014 at 07:00:37PM +0200, Jean-Michel Hautbois wrote:
> This code corrects endianness and avoids a sparse error.
> Tested with Lattice ECP3-35 with Freescale i.MX6.
> It also sends uevent in order to load it.
>
> Signed-off-by: Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>
> ---
> drivers/misc/lattice-ecp3-config.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/misc/lattice-ecp3-config.c
> b/drivers/misc/lattice-ecp3-config.c
> index bb26f08..f77ff4b 100644
> --- a/drivers/misc/lattice-ecp3-config.c
> +++ b/drivers/misc/lattice-ecp3-config.c
> @@ -16,6 +16,7 @@
> #include <linux/spi/spi.h>
> #include <linux/platform_device.h>
> #include <linux/delay.h>
> +#include <asm/unaligned.h>
>
> #define FIRMWARE_NAME "lattice-ecp3.bit"
>
> @@ -92,8 +93,8 @@ static void firmware_load(const struct firmware *fw,
> void *context)
> /* Trying to speak with the FPGA via SPI... */
> txbuf[0] = FPGA_CMD_READ_ID;
> ret = spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len);
> - dev_dbg(&spi->dev, "FPGA JTAG ID=%08x\n", *(u32 *)&rxbuf[4]);
> - jedec_id = *(u32 *)&rxbuf[4];
> + jedec_id = get_unaligned_be32(&rxbuf[4]);
> + dev_dbg(&spi->dev, "FPGA JTAG ID=%08x\n", jedec_id);

All tabs are converted to spaces, making this patch impossible to apply
:(


Can you fix that up and resend?

thanks,

greg k-h


\
 
 \ /
  Last update: 2014-07-23 02:01    [W:0.118 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site