Messages in this thread | | | Date | Tue, 22 Jul 2014 13:17:40 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private |
| |
On Tue, Jul 22, 2014 at 04:17:41PM +0900, Alexandre Courbot wrote: > As GPIO descriptors are not going to remain unique anymore, having this > function public is not safe. Restrain its use to gpiolib since we have > no user outside of it. > If I implement a gpio chip driver built as module, and I want to use gpiochip_request_own_desc(), how am I supposed to get desc ?
I understand that there is still gpio_to_desc(), but I would have thought that desc = gpiochip_get_desc(chip, pin); would be better than desc = gpio_to_desc(chip->base + pin);
Not that it makes much of a difference for me, just asking.
Thanks, Guenter
| |