lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arch: x86: boot: bioscall.S: simplify self-modification of the INT instruction
On 07/22/2014 04:01 AM, Klemen Jan Enova wrote:
> At the start of the intcall function, the %al register is compared to
> 0x3f. If it does not equal 0x3f it is equated to it. Instruction flow
> continues in both cases from the label 1. The comparison is therefore
> unneeded.
>
> Testing data is appended.
>
> Signed-off-and-tested-by: Klemen Jan Enova <klemen.jan.enova@gmail.com>

NAK.

This is a performance optimization - the SMC takes a substantial penalty
so the write is avoided if necessary.

Also, 3f is a label, not 0x3f.

-hpa



\
 
 \ /
  Last update: 2014-07-22 17:21    [W:0.040 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site