lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'


    On 07/22/2014 06:32 PM, Arnd Bergmann wrote:
    > On Sunday 20 July 2014 17:45:40 Chen Gang wrote:
    >>>
    >>> Next, I shall:
    >>>
    >>> - Remove HAS_IOMEM and NO_IOMEM from kernel, firstly.
    >>>
    >>> - Try to make dummy IOMEM functions for score architecture.
    >>>
    >>> - Continue discussing with UML for it.
    >>>
    >>
    >> Oh, sorry, I forgot, after remove IOMEM from kernel, also s390 and tile
    >> need implement dummy IOMEM if !PCI.
    >>
    >> If possible, I shall try to implement the dummy IOMEM in 'asm-generic',
    >> and let uml, score, s390 and tile use them when they need.
    >
    > Sorry for going round in circles, but looking back at the original patches,
    > adding the extra 'depends on HAS_IOMEM' does seem much better than the
    > other suggestions that came afterwards.
    >
    > In particular, removing HAS_IOMEM and NO_IOMEM sounds like an awful idea
    > to me. I'd rather add a HAS_IOPORT in addition to also catch architectures
    > that have no support for PC-style PIO.
    >

    Welcome any other members (especially driver members) ideas and
    suggestions -- driver members and architecture members have different
    tastes and different roles.

    For me, if no additional reply, I prefer to keep current status, and
    still add 'depends on HAS_IOMEM' for each driver which need it, but I am
    not sure whether driver members can bear it.


    Thanks.
    --
    Chen Gang

    Open, share, and attitude like air, water, and life which God blessed


    \
     
     \ /
      Last update: 2014-07-22 14:41    [W:3.382 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site