lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/52] perf tools: Fix incorrect fd error comparison
    Date
    Zero is a valid fd.  Error comparison should check
    for negative fd.

    Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    ---
    tools/perf/util/dso.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
    index fc006fe..28cf747 100644
    --- a/tools/perf/util/dso.c
    +++ b/tools/perf/util/dso.c
    @@ -216,7 +216,7 @@ static int open_dso(struct dso *dso, struct machine *machine)
    {
    int fd = __open_dso(dso, machine);

    - if (fd > 0) {
    + if (fd >= 0) {
    dso__list_add(dso);
    /*
    * Check if we crossed the allowed number
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2014-07-23 07:23    [W:4.054 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site