Messages in this thread | | | From | "Murphy, Dan" <> | Subject | Re: [PATCH 1/2] ASoC: tas2552: Fix PM sequencing | Date | Mon, 21 Jul 2014 13:23:17 +0000 |
| |
Mark
On 07/21/2014 07:19 AM, Mark Brown wrote: > On Fri, Jul 18, 2014 at 12:31:07PM -0500, Dan Murphy wrote: >> In the pm suspend/resume it is better >> to disable the GPIO after the regmap_cache >> setting calls so that if the call is interrupted >> the new reg values will be cached and set on resume. >> >> Also add pm_runtime_put in the remove call. > Applied, thanks, but please don't mix multiple changes into one commit > like this especially when there's no textual overlap.
I usually don't mix changes like this as I like to have a single change per commit.
But I find each maintainer is a little different but now I know for next time.
Thanks
-- ------------------ Dan Murphy
| |