Messages in this thread | | | Date | Wed, 2 Jul 2014 08:15:20 +0200 | Subject | Re: [PATCH] agp: remove read/write stubs | From | Mathias Krause <> |
| |
On 15 June 2014 23:02, Mathias Krause <minipli@googlemail.com> wrote: > The VFS layer handles those in the very same way, if unset. No need for > additional stubs. > > Signed-off-by: Mathias Krause <minipli@googlemail.com> > Cc: Alexander Viro <viro@zeniv.linux.org.uk> > --- > drivers/char/agp/frontend.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/frontend.c > index b29703324e..09f17eb734 100644 > --- a/drivers/char/agp/frontend.c > +++ b/drivers/char/agp/frontend.c > @@ -710,19 +710,6 @@ static int agp_open(struct inode *inode, struct file *file) > return 0; > } > > - > -static ssize_t agp_read(struct file *file, char __user *buf, > - size_t count, loff_t * ppos) > -{ > - return -EINVAL; > -} > - > -static ssize_t agp_write(struct file *file, const char __user *buf, > - size_t count, loff_t * ppos) > -{ > - return -EINVAL; > -} > - > static int agpioc_info_wrap(struct agp_file_private *priv, void __user *arg) > { > struct agp_info userinfo; > @@ -1047,8 +1034,6 @@ static const struct file_operations agp_fops = > { > .owner = THIS_MODULE, > .llseek = no_llseek, > - .read = agp_read, > - .write = agp_write, > .unlocked_ioctl = agp_ioctl, > #ifdef CONFIG_COMPAT > .compat_ioctl = compat_agp_ioctl, > -- > 1.7.10.4 >
Ping. Any objections, comments? David?
| |