lkml.org 
[lkml]   [2014]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 09/11] capsicum: implementations of new LSM hooks
Date
On Monday, June 30, 2014 09:05:38 AM Andy Lutomirski wrote:
> On Mon, Jun 30, 2014 at 3:28 AM, David Drysdale <drysdale@google.com> wrote:
> > If the LSM does not provide implementations of the .file_lookup and
> > .file_install LSM hooks, always use the Capsicum implementations.
> >
> > The Capsicum implementation of file_lookup checks for a Capsicum
> > capability wrapper file and unwraps to if the appropriate rights
> > are available.
> >
> > The Capsicum implementation of file_install checks whether the file
> > has restricted rights associated with it. If it does, it is replaced
> > with a Capsicum capability wrapper file before installation into the
> > fdtable.
>
> I think I fall on the "no LSM" side of the fence. This kind of stuff
> should be available regardless of selected LSM (as it is in your
> code) ...

I agree. Looking quickly at the patches, the code seems to take an odd
approach of living largely outside the LSM framework, but then relying on a
couple of LSM hooks. Capsicum should either live fully as a LSM or fully
outside of it, this mix seems a bit silly to me.

--
paul moore
www.paul-moore.com



\
 
 \ /
  Last update: 2014-07-02 16:41    [W:0.081 / U:0.228 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site