lkml.org 
[lkml]   [2014]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V4 10/16] perf, core: simplify need branch stack check
From
On Wed, Jul 2, 2014 at 12:57 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, Jun 30, 2014 at 04:50:47PM +0800, Yan, Zheng wrote:
>> event->attr.branch_sample_type is non-zero no matter branch stack
>> is enabled explicitly or is enabled implicitly. we can use it to
>> replace intel_pmu_needs_lbr_smpl(). This avoids duplicating code
>> that implicitly enables the LBR.
>
> How so? I grep'ed for a minute but could not find what you're referring
> to.

If !(attr->sample_type & PERF_SAMPLE_BRANCH_STACK), then
event->attr.branch_type = 0. If the sample_type is set, then branch_type
is necessarily non-zero.


\
 
 \ /
  Last update: 2014-07-02 13:21    [W:0.085 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site