lkml.org 
[lkml]   [2014]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] PM / Hibernate: Create a Radix-Tree to store memory bitmap
On Sat, Jul 19, 2014 at 02:00:39AM +0200, Rafael J. Wysocki wrote:
> > +/*
> > + * alloc_rtree_node - Allocate a new node and add it to the radix
> > + * tree.
>
> Please make this a single line.
>
> > +static int add_rtree_block(struct mem_zone_bm_rtree *zone, gfp_t gfp_mask,
> > + int safe_needed, struct chain_allocator *ca)
> > +{
> > + struct rtree_node *node, *block, **dst;
> > + unsigned int levels_needed, block_nr;
> > + int i;
> > +
> > + block_nr = zone->blocks;
>
> This isn't proper kernel coding style. Please use spaces as separators
> before the "=" here and elsewhere.

Thanks for your comments, will fix this and resend next week.


Joerg



\
 
 \ /
  Last update: 2014-07-19 10:41    [W:0.115 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site