lkml.org 
[lkml]   [2014]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[RESEND PATCH] powerpc/fsl-pci: Correct use of ! and &
    In commit ae91d60ba88ef0bdb1b5e9b2363bd52fc45d2af7, a bug was fixed that
    involved converting !x & y to !(x & y). The code below shows the same
    pattern, and thus should perhaps be fixed in the same way.

    This is not tested and clearly changes the semantics, so it is only
    something to consider.

    The Coccinelle semantic patch that makes this change is as follows:

    // <smpl>
    @@ expression E1,E2; @@
    (
    !E1 & !E2
    |
    - !E1 & E2
    + !(E1 & E2)
    )
    // </smpl>

    Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
    ---
    arch/powerpc/sysdev/fsl_pci.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
    index 4bd091a..c507767 100644
    --- a/arch/powerpc/sysdev/fsl_pci.c
    +++ b/arch/powerpc/sysdev/fsl_pci.c
    @@ -853,8 +853,8 @@ u64 fsl_pci_immrbar_base(struct pci_controller *hose)
    in = pcie->cfg_type0 + PEX_RC_INWIN_BASE;
    for (i = 0; i < 4; i++) {
    /* not enabled, skip */
    - if (!in_le32(&in[i].ar) & PEX_RCIWARn_EN)
    - continue;
    + if (!(in_le32(&in[i].ar) & PEX_RCIWARn_EN))
    + continue;

    if (get_immrbase() == in_le32(&in[i].tar))
    return (u64)in_le32(&in[i].barh) << 32 |
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-07-20 00:21    [W:4.944 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site