lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 23/25] virtio: Replace DEFINE_PCI_DEVICE_TABLE macro use
    Date
    We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
    kernel coding style guidelines. This issue was reported by checkpatch.

    Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>

    ---
    Tested by compilation without errors.

    drivers/virtio/virtio_pci.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
    index 101db3f..3d1463c 100644
    --- a/drivers/virtio/virtio_pci.c
    +++ b/drivers/virtio/virtio_pci.c
    @@ -91,7 +91,7 @@ struct virtio_pci_vq_info
    };

    /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */
    -static DEFINE_PCI_DEVICE_TABLE(virtio_pci_id_table) = {
    +static const struct pci_device_id virtio_pci_id_table[] = {
    { PCI_DEVICE(0x1af4, PCI_ANY_ID) },
    { 0 }
    };


    \
     
     \ /
      Last update: 2014-07-19 10:21    [W:3.790 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site