lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] usb: musb: core: cleanup - remove some useless 'break's from switch statements
HI,

On Fri, Jul 18, 2014 at 11:31:22AM +0200, Lothar Waßmann wrote:
>

no commit log == no commit, also the worst thing you can do is have your
bug fixes depend on cleanups. This is *not* a bug fix by any stretch of
the imagination.

> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
> drivers/usb/musb/musb_core.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index b841ee0..8623112 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -680,7 +680,6 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
> default:
> /* "should not happen" */
> musb->is_active = 0;
> - break;
> }
> }
>
> @@ -737,7 +736,6 @@ b_host:
> if (hcd)
> hcd->self.is_b_host = 0;
> }
> - break;
> }
>
> musb_host_poke_root_hub(musb);
> @@ -787,7 +785,6 @@ b_host:
> default:
> WARNING("unhandled DISCONNECT transition (%s)\n",
> usb_otg_state_string(musb->xceiv->state));
> - break;
> }
> }
>
> @@ -2015,7 +2012,6 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
> break;
> default:
> dev_err(dev, "unsupported port mode %d\n", musb->port_mode);
> - break;
> }
>
> if (status < 0)
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-07-19 02:41    [W:0.177 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site