Messages in this thread | | | Date | Fri, 18 Jul 2014 19:18:13 +0200 | From | walter harms <> | Subject | Re: [PATCH 4/5] kernel/debug/kdb/kdb_bp.c: drop negativity check on unsigned value |
| |
Am 18.07.2014 17:34, schrieb Andrey Utkin: > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80591 > Reported-by: David Binderman <dcb314@hotmail.com> > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com> > --- > kernel/debug/kdb/kdb_bp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c > index 70a5046..f27dfb8 100644 > --- a/kernel/debug/kdb/kdb_bp.c > +++ b/kernel/debug/kdb/kdb_bp.c > @@ -39,7 +39,7 @@ static char *kdb_rwtypes[] = { > > static char *kdb_bptype(kdb_bp_t *bp) > { > - if (bp->bp_type < 0 || bp->bp_type > 4) > + if (bp->bp_type > 4) > return ""; > > return kdb_rwtypes[bp->bp_type];
i would expect a ckeck for the upper limit with ARRAY_SIZE(bp->bp_type) here.
re, wh
| |