lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 033/170] SUNRPC: Fix a module reference leak in svc_handle_xprt
    Date
    From: Trond Myklebust <trond.myklebust@primarydata.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit c789102c20bbbdda6831a273e046715be9d6af79 upstream.

    If the accept() call fails, we need to put the module reference.

    Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    net/sunrpc/svc_xprt.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
    index 80a6640f329b..b9aad4723a9d 100644
    --- a/net/sunrpc/svc_xprt.c
    +++ b/net/sunrpc/svc_xprt.c
    @@ -730,6 +730,8 @@ static int svc_handle_xprt(struct svc_rqst *rqstp, struct svc_xprt *xprt)
    newxpt = xprt->xpt_ops->xpo_accept(xprt);
    if (newxpt)
    svc_add_new_temp_xprt(serv, newxpt);
    + else
    + module_put(xprt->xpt_class->xcl_owner);
    } else if (xprt->xpt_ops->xpo_has_wspace(xprt)) {
    /* XPT_DATA|XPT_DEFERRED case: */
    dprintk("svc: server %p, pool %u, transport %p, inuse=%d\n",
    --
    2.0.0


    \
     
     \ /
      Last update: 2014-07-18 19:21    [W:3.049 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site