lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 008/170] target: Fix left-over se_lun->lun_sep pointer OOPs
    Date
    From: Nicholas Bellinger <nab@linux-iscsi.org>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 83ff42fcce070801a3aa1cd6a3269d7426271a8d upstream.

    This patch fixes a left-over se_lun->lun_sep pointer OOPs when one
    of the /sys/kernel/config/target/$FABRIC/$WWPN/$TPGT/lun/$LUN/alua*
    attributes is accessed after the $DEVICE symlink has been removed.

    To address this bug, go ahead and clear se_lun->lun_sep memory in
    core_dev_unexport(), so that the existing checks for show/store
    ALUA attributes in target_core_fabric_configfs.c work as expected.

    Reported-by: Sebastian Herbszt <herbszt@gmx.de>
    Tested-by: Sebastian Herbszt <herbszt@gmx.de>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/target/target_core_device.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
    index e31ec5cf0c36..c7a3c5e2b1b3 100644
    --- a/drivers/target/target_core_device.c
    +++ b/drivers/target/target_core_device.c
    @@ -617,6 +617,7 @@ void core_dev_unexport(
    dev->export_count--;
    spin_unlock(&hba->device_lock);

    + lun->lun_sep = NULL;
    lun->lun_se_dev = NULL;
    }

    --
    2.0.0


    \
     
     \ /
      Last update: 2014-07-18 17:41    [W:4.082 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site