Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 1/4 v2] iio: exyno-adc: use syscon for PMU register access | Date | Thu, 17 Jul 2014 15:56:55 +0200 |
| |
Hi,
On Thursday, July 17, 2014 05:41:16 PM Naveen Krishna Ch wrote: > Hello Sachin, > > On 17 July 2014 17:24, Sachin Kamat <spk.linux@gmail.com> wrote: > > Hi Naveen, > > > > On Thu, Jul 17, 2014 at 4:49 PM, Naveen Krishna Chatradhi > > <ch.naveen@samsung.com> wrote: > >> This patch updates the IIO based ADC driver to use syscon and regmap > >> APIs to access and use PMU registers instead of remapping the PMU > >> registers in the driver. > >> > >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > >> To: linux-iio@vger.kernel.org > > > > With only this patch applied, I believe the ADC functionality would be broken. > > Perhaps the DT changes should be merged along with this patch? > > Jonathan already mentioned that, he would wait for Ack from Kukjin. > With out the dts changes ADC driver will fail to probe but it wont > crash the system. > git bisect should still work.
Unless someone bisects things related to ADC functionality..
Also patch #1 seems to break device tree ABI (the old dtb will no longer work with the new kernel).
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
| |