Messages in this thread | | | Date | Thu, 17 Jul 2014 15:53:46 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 04/10] proc: fix PAGE_SIZE limit of /proc/$PID/cmdline |
| |
On Thu, 17 Jul 2014 00:32:47 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Convert /proc/$PID/cmdline to seq_file interface. > > XXX
Unsure what XXX signifies.
> This one must be buggy. > > seq_file buffer is adjustable, so userspace can execute itself > with huge command line (which can be arbitrarily long now), then read 1 byte. > > Voila, whole command line now is in kmalloced/vmalloced memory. > > Imposing limit is trivial but equally lame to current PAGE_SIZE limit.
Confused. Why send the patch if you don't like it?
Why not go ahead and impose the PAGE_SIZE limit?
| |