Messages in this thread | | | Date | Thu, 17 Jul 2014 12:01:52 -0700 | From | Zach Brown <> | Subject | Re: [PATCH 1/1] Btrfs: fix sparse warning |
| |
> > > @@ -515,7 +515,8 @@ static int write_buf(struct file *filp, const void *buf, > > > u32 len, loff_t *off) > > > > Though this probably wants to be rewritten in terms of kernel_write(). > > That'd give an opportunity to get rid of the sctx->send_off and have it > > use f_pos in the filp. > > Do you mean directly call kernel_write from send_cmd/send_header ? > I guess that loop around vfs_write in write_buf is there for something ...
write_buf() could still exist to iterate over the buffer in the case of partial writes but it doesn't need to muck around with set_fs() and forcing casts.
- z
| |