Messages in this thread | | | Date | Thu, 17 Jul 2014 02:44:20 +1000 (EST) | From | James Morris <> | Subject | Re: [PATCH v10 0/11] seccomp: add thread sync ability |
| |
On Fri, 11 Jul 2014, Kees Cook wrote:
> On Fri, Jul 11, 2014 at 9:49 AM, Oleg Nesterov <oleg@redhat.com> wrote: > > On 07/10, Kees Cook wrote: > >> > >> This adds the ability for threads to request seccomp filter > >> synchronization across their thread group (at filter attach time). > >> For example, for Chrome to make sure graphic driver threads are fully > >> confined after seccomp filters have been attached. > >> > >> To support this, locking on seccomp changes via thread-group-shared > >> sighand lock is introduced, along with refactoring of no_new_privs. Races > >> with thread creation are handled via delayed duplication of the seccomp > >> task struct field and cred_guard_mutex. > >> > >> This includes a new syscall (instead of adding a new prctl option), > >> as suggested by Andy Lutomirski and Michael Kerrisk. > > > > I do not not see any problems in this version, > > Awesome! Thank you for all the reviews. :) If Andy and Michael are > happy with this too, I think this is in good shape. \o/ > > -Kees
If you re-send this, please add Oleg's Reviewed-by to each patch.
> > > > > Reviewed-by: Oleg Nesterov <oleg@redhat.com> > > > > > >
-- James Morris <jmorris@namei.org>
| |