lkml.org 
[lkml]   [2014]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: gdm72xx: conditionally compile debug code
On 07/09/2014 07:51 PM, Greg KH wrote:
>> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c
>> index 9d2de6f..914fd75 100644
>> --- a/drivers/staging/gdm72xx/gdm_sdio.c
>> +++ b/drivers/staging/gdm72xx/gdm_sdio.c
>> @@ -280,9 +280,11 @@ static void send_sdu(struct sdio_func *func, struct tx_cxt *tx)
>>
>> spin_unlock_irqrestore(&tx->lock, flags);
>>
>> + #if defined(GDM72xx_DEBUG)
>> print_hex_dump_debug("sdio_send: ", DUMP_PREFIX_NONE, 16, 1,
>> tx->sdu_buf + TYPE_A_HEADER_SIZE,
>> aggr_len - TYPE_A_HEADER_SIZE, false);
>> + #endif
>
> This should be moved to use dev_dbg(), along with the other calls to
> this function in this file.
>

But dev_dbg() gets eventually to be printk(), which cannot print the
buffer, so using print_hex_dump_debug() seems to be correct for this
case, no?



\
 
 \ /
  Last update: 2014-07-16 23:21    [W:0.131 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site